Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 SAST: add Snyk probe #3689

Merged
merged 13 commits into from
Dec 19, 2023
Merged

🌱 SAST: add Snyk probe #3689

merged 13 commits into from
Dec 19, 2023

Conversation

DavidKorczynski
Copy link
Contributor

Adds Snyk's GitHub action (https://github.com/snyk/actions) as a probe.

What kind of change does this PR introduce?

Adds a probe checking the presence of Snyk SAST GitHub action.

What is the current behavior?

Scorecard will not recognize Snyk scanning as a SAST action.

What is the new behavior (if this is a feature change)?**

Scorecard will recognize Snyk scanning as a SAST action.

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Ref: #2318

Special notes for your reviewer

Does this PR introduce a user-facing change?

Yes, in that it will change scoring of projects that use Snyk and users may now see Snyk-related details in the output.

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


Adds Snyk's GitHub action (https://github.com/snyk/actions) as a probe.

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski DavidKorczynski requested a review from a team as a code owner November 21, 2023 10:14
@DavidKorczynski DavidKorczynski requested review from raghavkaul and laurentsimon and removed request for a team November 21, 2023 10:14
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #3689 (dccaf34) into main (21bbe80) will decrease coverage by 5.28%.
The diff coverage is 70.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3689      +/-   ##
==========================================
- Coverage   76.09%   70.81%   -5.28%     
==========================================
  Files         216      217       +1     
  Lines       14966    15061      +95     
==========================================
- Hits        11388    10666     -722     
- Misses       2892     3753     +861     
+ Partials      686      642      -44     

@DavidKorczynski DavidKorczynski changed the title SAST: add Snyk probe 🌱 SAST: add Snyk probe Nov 21, 2023
Signed-off-by: David Korczynski <[email protected]>
Copy link

github-actions bot commented Dec 2, 2023

This pull request is stale because it has been open for 10 days with no activity

@github-actions github-actions bot added the Stale label Dec 2, 2023
Signed-off-by: DavidKorczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
checks/evaluation/sast.go Outdated Show resolved Hide resolved
checks/evaluation/sast.go Outdated Show resolved Hide resolved
checks/evaluation/sast_test.go Outdated Show resolved Hide resolved
checks/raw/sast.go Show resolved Hide resolved
checks/raw/sast.go Outdated Show resolved Hide resolved
probes/sastToolSnykInstalled/def.yml Show resolved Hide resolved
probes/sastToolSnykInstalled/impl.go Show resolved Hide resolved
@github-actions github-actions bot removed the Stale label Dec 13, 2023
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one minor change.

checks/raw/sast.go Outdated Show resolved Hide resolved
probes/sastToolSnykInstalled/def.yml Show resolved Hide resolved
Signed-off-by: David Korczynski <[email protected]>
@spencerschrock
Copy link
Member

/scdiff generate SAST

Copy link

@spencerschrock
Copy link
Member

/scdiff generate SAST

Copy link

@spencerschrock spencerschrock merged commit 2ef20f1 into ossf:main Dec 19, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants